[ 
https://issues.apache.org/jira/browse/HIVE-11699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725818#comment-14725818
 ] 

Sergey Shelukhin commented on HIVE-11699:
-----------------------------------------

nit: {noformat}Pattern tpat = Pattern.compile("[\\w_]+");{noformat} could be 
done once as a global.
{noformat}m = tpat.matcher(String.valueOf(c));{noformat} this seems a little 
bit excessive. Is it possible to check using Character.isBlah() methods?
The tests are definitely needed.
Should this also apply to column names, etc.? Are you sure checkTableName will 
be called everywhere i.e. when CLI, beeline or some GUI displays table names 
from metastore?


> Support special characters in quoted table names
> ------------------------------------------------
>
>                 Key: HIVE-11699
>                 URL: https://issues.apache.org/jira/browse/HIVE-11699
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Pengcheng Xiong
>            Assignee: Pengcheng Xiong
>         Attachments: HIVE-11699.01.patch
>
>
> Right now table names can only be "[a-zA-z_0-9]+". This patch tries to 
> investigate how much change there should be if we would like to support 
> special characters, e.g., "/" in table names.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to