[ https://issues.apache.org/jira/browse/HIVE-22608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17001262#comment-17001262 ]
Hive QA commented on HIVE-22608: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12989280/HIVE-22608.01.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 24 failed/errored test(s), 17786 tests executed *Failed tests:* {noformat} org.apache.hive.beeline.cli.TestHiveCli.testCmd (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testCommentStripping (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testDatabaseOptions (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testErrOutput (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testHelp (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testInValidCmd (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testInvalidDatabaseOptions (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testInvalidOptions (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testInvalidOptions2 (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testNoErrorDB (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testSetHeaderValue (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testSetPromptValue (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testSourceCmd (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testSourceCmd2 (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testSourceCmd3 (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testSourceCmd4 (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testSqlFromCmd (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testSqlFromCmdWithDBName (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testUseCurrentDB1 (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testUseCurrentDB2 (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testUseCurrentDB3 (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testUseInvalidDB (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testVariables (batchId=206) org.apache.hive.beeline.cli.TestHiveCli.testVariablesForSource (batchId=206) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19995/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19995/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19995/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 24 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12989280 - PreCommit-HIVE-Build > Reduce the number of public methods in Driver > --------------------------------------------- > > Key: HIVE-22608 > URL: https://issues.apache.org/jira/browse/HIVE-22608 > Project: Hive > Issue Type: Sub-task > Components: Hive > Reporter: Miklos Gergely > Assignee: Miklos Gergely > Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22608.01.patch > > > There are 33 public methods in Driver, some of them either don't belong > there, or should not be public. -- This message was sent by Atlassian Jira (v8.3.4#803005)