[
https://issues.apache.org/jira/browse/HIVE-22736?focusedWorklogId=376191&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-376191
]
ASF GitHub Bot logged work on HIVE-22736:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jan/20 11:11
Start Date: 23/Jan/20 11:11
Worklog Time Spent: 10m
Work Description: maheshk114 commented on pull request #883: HIVE-22736
Support multiple encryption zones in replication
URL: https://github.com/apache/hive/pull/883#discussion_r370053902
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -2835,17 +2834,25 @@ private boolean checkTableDataShouldBeDeleted(Table
tbl, boolean deleteData) {
* @param tablePath
* @param ifPurge completely purge the table (skipping trash) while
removing
* data from warehouse
- * @param db database the table belongs to
+ * @param shouldEnableCm If cm should be enabled
*/
- private void deleteTableData(Path tablePath, boolean ifPurge, Database db)
{
+ private void deleteTableData(Path tablePath, boolean ifPurge, boolean
shouldEnableCm) throws MetaException {
+ if (tablePath != null) {
+ wh.deleteDir(tablePath, true, ifPurge, shouldEnableCm);
+ }
+ }
+ /**
+ * Deletes the data in a table's location, if it fails logs an error.
+ *
+ * @param tablePath
+ * @param ifPurge completely purge the table (skipping trash) while
removing
+ * data from warehouse
+ * @param db Database
+ */
+ private void deleteTableData(Path tablePath, boolean ifPurge, Database db)
throws MetaException {
if (tablePath != null) {
- try {
- wh.deleteDir(tablePath, true, ifPurge, db);
- } catch (Exception e) {
- LOG.error("Failed to delete table directory: " + tablePath +
- " " + e.getMessage());
- }
+ wh.deleteDir(tablePath, true, ifPurge, db);
Review comment:
for now ..just log the error ..ignore the exception while deleting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 376191)
Time Spent: 40m (was: 0.5h)
> Support replication across multiple encryption zones
> ----------------------------------------------------
>
> Key: HIVE-22736
> URL: https://issues.apache.org/jira/browse/HIVE-22736
> Project: Hive
> Issue Type: Task
> Reporter: Aasha Medhi
> Assignee: Aasha Medhi
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22736.patch, HIVE-22736.patch, HIVE-22736.patch,
> HIVE-22736.patch, HIVE-22736.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
