[ 
https://issues.apache.org/jira/browse/HIVE-22821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035643#comment-17035643
 ] 

Slim Bouguerra commented on HIVE-22821:
---------------------------------------

Hi [~szita] can you please submit a pull request,
My first comment is to avoid mangling the llap caching the proto buff sutff, i 
recommend something like this
{code} 
/**
   * @param predicate filter selecting the buffers to be evicted
   * @return amount of evicted bytes.
   */
  long evict(Predicate<LlapAllocatorBuffer> predicate);

{code}

> Add necessary endpoints for proactive cache eviction
> ----------------------------------------------------
>
>                 Key: HIVE-22821
>                 URL: https://issues.apache.org/jira/browse/HIVE-22821
>             Project: Hive
>          Issue Type: Sub-task
>          Components: llap
>            Reporter: Ádám Szita
>            Assignee: Ádám Szita
>            Priority: Major
>         Attachments: HIVE-22821.0.patch, HIVE-22821.1.patch, 
> HIVE-22821.2.patch
>
>
> Implement the parts required for iHS2 -> LLAP daemons communication:
>  * protobuf message schema and endpoints
>  * Hive configuration
>  * for use cases:
>  ** dropping db
>  ** dropping table
>  ** dropping partition from a table



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to