[ https://issues.apache.org/jira/browse/HIVE-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736103#comment-14736103 ]
Xuefu Zhang commented on HIVE-11746: ------------------------------------ [~Ferd], thanks for the explanation. The new changes seem working, but it still seems a little confusing. Dispatch() method now takes a new param, but this is only needed by embeddedConnect() and we have to burden other callers to pass a value to this param any way. Looking at embeddedConnect(), I'm wondering if we just call execCommandWithPrefix() directly. This is because when we connect in the embedded mode, the command is a constant, and we don't need any of the processing in dispatch(). This way, the dispatch() method becomes cleaner. What do you think? > Connect command should not to be allowed from user[beeline-cli branch] > ---------------------------------------------------------------------- > > Key: HIVE-11746 > URL: https://issues.apache.org/jira/browse/HIVE-11746 > Project: Hive > Issue Type: Sub-task > Components: Beeline > Reporter: Ferdinand Xu > Assignee: Ferdinand Xu > Fix For: beeline-cli-branch > > Attachments: HIVE-11746.1-beeline-cli.patch, > HIVE-11746.2-beeline-cli.patch > > > For new cli, user should not be allowed to connect a server or database. -- This message was sent by Atlassian JIRA (v6.3.4#6332)