[ https://issues.apache.org/jira/browse/HIVE-22895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037893#comment-17037893 ]
Hive QA commented on HIVE-22895: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12993593/HIVE-22895.01.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17994 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[merge_negative_4] (batchId=106) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/20673/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20673/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20673/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12993593 - PreCommit-HIVE-Build > Break up DDLSemanticAnalyzer - extract Table storage analyzers > -------------------------------------------------------------- > > Key: HIVE-22895 > URL: https://issues.apache.org/jira/browse/HIVE-22895 > Project: Hive > Issue Type: Sub-task > Reporter: Miklos Gergely > Assignee: Miklos Gergely > Priority: Major > Labels: refactor-ddl > Attachments: HIVE-22895.01.patch > > > DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is > to refactor it in order to have everything cut into more handleable classes > under the packageĀ org.apache.hadoop.hive.ql.exec.ddl: > * have a separate class for each analyzers > * have a package for each operation, containing an analyzer, a description, > and an operation, so the amount of classes under a package is more manageable > Step #14: extract the table storage related analyzers from > DDLSemanticAnalyzer, and move them under the new package. -- This message was sent by Atlassian Jira (v8.3.4#803005)