[
https://issues.apache.org/jira/browse/HIVE-22860?focusedWorklogId=388207&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-388207
]
ASF GitHub Bot logged work on HIVE-22860:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Feb/20 06:06
Start Date: 17/Feb/20 06:06
Worklog Time Spent: 10m
Work Description: maheshk114 commented on pull request #900: HIVE-22860
Support metadata only replication for external tables
URL: https://github.com/apache/hive/pull/900#discussion_r379991400
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -493,7 +494,8 @@ Long bootStrapDump(Path dumpRoot, DumpMetaData dmd, Path
cmRoot, Hive hiveDb)
Exception caught = null;
boolean shouldWriteExternalTableLocationInfo =
conf.getBoolVar(HiveConf.ConfVars.REPL_INCLUDE_EXTERNAL_TABLES)
- &&
!conf.getBoolVar(HiveConf.ConfVars.REPL_DUMP_METADATA_ONLY);
+ &&
(!conf.getBoolVar(HiveConf.ConfVars.REPL_DUMP_METADATA_ONLY) &&
Review comment:
why not use shouldDumpExternalTableLocation to check ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 388207)
Time Spent: 1.5h (was: 1h 20m)
> Support metadata only replication for external tables
> -----------------------------------------------------
>
> Key: HIVE-22860
> URL: https://issues.apache.org/jira/browse/HIVE-22860
> Project: Hive
> Issue Type: Task
> Reporter: Aasha Medhi
> Assignee: Aasha Medhi
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22860.patch, HIVE-22860.patch, HIVE-22860.patch,
> HIVE-22860.patch, HIVE-22860.patch, HIVE-22860.patch, HIVE-22860.patch,
> HIVE-22860.patch, HIVE-22860.patch
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
