[ https://issues.apache.org/jira/browse/HIVE-22877?focusedWorklogId=389552&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389552 ]
ASF GitHub Bot logged work on HIVE-22877: ----------------------------------------- Author: ASF GitHub Bot Created on: 19/Feb/20 18:36 Start Date: 19/Feb/20 18:36 Worklog Time Spent: 10m Work Description: mustafaiman commented on pull request #905: HIVE-22877: Fix decimal boundary for casting to Decimal64 URL: https://github.com/apache/hive/pull/905 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 389552) Time Spent: 20m (was: 10m) > Fix decimal boundary check for casting to Decimal64 > --------------------------------------------------- > > Key: HIVE-22877 > URL: https://issues.apache.org/jira/browse/HIVE-22877 > Project: Hive > Issue Type: Bug > Components: Vectorization > Affects Versions: 4.0.0 > Reporter: Mustafa Iman > Assignee: Mustafa Iman > Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22877.1.patch, HIVE-22877.1.patch, > HIVE-22877.1.patch, HIVE-22877.patch > > Time Spent: 20m > Remaining Estimate: 0h > > During vectorization, decimal fields that are obtained via generic udfs are > cast to Decimal64 in some circumstances. For decimal to decimal64 cast, hive > compares the source column's `scale + precision` to 18(maximum number of > digits that can be represented by a long). A decimal can fit in a long as > long as its `precision` is smaller than or equal to 18. Scale is irrelevant. > Since vectorized generic udf expression takes scale into account, it computes > wrong output column vector: Decimal instead of Decimal64. This in turn causes > ClassCastException down the operator chain. > Below query fails with class cast exception: > > {code:java} > create table mini_store > ( > s_store_sk int, > s_store_id string > ) > row format delimited fields terminated by '\t' > STORED AS ORC; > create table mini_sales > ( > ss_store_sk int, > ss_quantity int, > ss_sales_price decimal(7,2) > ) > row format delimited fields terminated by '\t' > STORED AS ORC; > insert into mini_store values (1, 'store'); > insert into mini_sales values (1, 2, 1.2); > select s_store_id, coalesce(ss_sales_price*ss_quantity,0) sumsales > from mini_sales, mini_store where ss_store_sk = s_store_sk > {code} > > -- This message was sent by Atlassian Jira (v8.3.4#803005)