[
https://issues.apache.org/jira/browse/HIVE-21218?focusedWorklogId=390174&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-390174
]
ASF GitHub Bot logged work on HIVE-21218:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/20 19:00
Start Date: 20/Feb/20 19:00
Worklog Time Spent: 10m
Work Description: davidov541 commented on pull request #526: HIVE-21218:
KafkaSerDe doesn't support topics created via Confluent
URL: https://github.com/apache/hive/pull/526#discussion_r382194556
##########
File path:
kafka-handler/src/test/org/apache/hadoop/hive/kafka/AvroBytesConverterTest.java
##########
@@ -0,0 +1,85 @@
+package org.apache.hadoop.hive.kafka;
+
+import com.google.common.collect.Maps;
+import io.confluent.kafka.schemaregistry.client.MockSchemaRegistryClient;
+import io.confluent.kafka.serializers.KafkaAvroSerializer;
+import org.apache.avro.Schema;
+import org.apache.hadoop.hive.serde2.avro.AvroGenericRecordWritable;
+import org.junit.Assert;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import java.util.Map;
+
+/**
+ * Test class for Hive Kafka Avro bytes converter.
+ */
+public class AvroBytesConverterTest {
+
+ private static SimpleRecord simpleRecord1 =
SimpleRecord.newBuilder().setId("123").setName("test").build();
+ private static byte[] simpleRecord1AsBytes;
+
+ /**
+ * Emulate confluent avro producer that add 4 magic bits (int) before
value bytes. The int represents the schema ID from schema registry.
+ */
+ @BeforeClass
+ public static void setUp() {
+ Map<String,String> config = Maps.newHashMap();
+ config.put("schema.registry.url","http://localhost";);
+ KafkaAvroSerializer avroSerializer = new KafkaAvroSerializer(new
MockSchemaRegistryClient());
+ avroSerializer.configure(config, false);
+ simpleRecord1AsBytes = avroSerializer.serialize("temp", simpleRecord1);
+ }
+
+ /**
+ * Emulate - avro.serde.type = none (Default)
+ */
+ @Test
+ public void convertWithAvroBytesConverter() {
+ Schema schema = SimpleRecord.getClassSchema();
+ KafkaSerDe.AvroBytesConverter conv = new
KafkaSerDe.AvroBytesConverter(schema);
+ AvroGenericRecordWritable simpleRecord1Writable =
conv.getWritable(simpleRecord1AsBytes);
+
+ Assert.assertNotNull(simpleRecord1Writable);
+
Assert.assertEquals(SimpleRecord.class,simpleRecord1Writable.getRecord().getClass());
+
+ SimpleRecord simpleRecord1Deserialized = (SimpleRecord)
simpleRecord1Writable.getRecord();
+
+ Assert.assertNotNull(simpleRecord1Deserialized);
+ Assert.assertNotEquals(simpleRecord1, simpleRecord1Deserialized);
+ }
+
+
+ /**
+ * Emulate - avro.serde.type = confluent
+ */
+ @Test
+ public void convertWithConfluentAvroBytesConverter() {
Review comment:
No test for avro.serde.type = skip?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 390174)
Time Spent: 4h 40m (was: 4.5h)
> KafkaSerDe doesn't support topics created via Confluent Avro serializer
> -----------------------------------------------------------------------
>
> Key: HIVE-21218
> URL: https://issues.apache.org/jira/browse/HIVE-21218
> Project: Hive
> Issue Type: Bug
> Components: kafka integration, Serializers/Deserializers
> Affects Versions: 3.1.1
> Reporter: Milan Baran
> Assignee: Milan Baran
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21218.2.patch, HIVE-21218.patch
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> According to [Google
> groups|https://groups.google.com/forum/#!topic/confluent-platform/JYhlXN0u9_A]
> the Confluent avro serialzier uses propertiary format for kafka value -
> <magic_byte 0x00><4 bytes of schema ID><regular avro bytes for object that
> conforms to schema>.
> This format does not cause any problem for Confluent kafka deserializer which
> respect the format however for hive kafka handler its bit a problem to
> correctly deserialize kafka value, because Hive uses custom deserializer from
> bytes to objects and ignores kafka consumer ser/deser classes provided via
> table property.
> It would be nice to support Confluent format with magic byte.
> Also it would be great to support Schema registry as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
