[ 
https://issues.apache.org/jira/browse/HIVE-22865?focusedWorklogId=395656&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-395656
 ]

ASF GitHub Bot logged work on HIVE-22865:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Mar/20 18:32
            Start Date: 01/Mar/20 18:32
    Worklog Time Spent: 10m 
      Work Description: aasha commented on pull request #911: HIVE-22865 
Include data in replication staging directory
URL: https://github.com/apache/hive/pull/911#discussion_r386129803
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
 ##########
 @@ -582,10 +586,19 @@ void dumpTable(String dbName, String tblName, String 
validTxnList, Path dbRoot,
     }
     MmContext mmCtx = MmContext.createIfNeeded(tableSpec.tableHandle);
     tuple.replicationSpec.setRepl(true);
-    new TableExport(
-        exportPaths, tableSpec, tuple.replicationSpec, hiveDb, distCpDoAsUser, 
conf, mmCtx).write();
-
+    List<ReplPathMapping> replPathMappings = new TableExport(
+            exportPaths, tableSpec, tuple.replicationSpec, hiveDb, 
distCpDoAsUser, conf, mmCtx).write(false);
     replLogger.tableLog(tblName, tableSpec.tableHandle.getTableType());
+    if (Utils.shouldDumpMetaDataOnly(tuple.object, conf)) {
 
 Review comment:
   Why is this check needed here? Is it not done previously
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 395656)
    Time Spent: 2h 40m  (was: 2.5h)

> Include data in replication staging directory
> ---------------------------------------------
>
>                 Key: HIVE-22865
>                 URL: https://issues.apache.org/jira/browse/HIVE-22865
>             Project: Hive
>          Issue Type: Task
>            Reporter: PRAVIN KUMAR SINHA
>            Assignee: PRAVIN KUMAR SINHA
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-22865.1.patch, HIVE-22865.2.patch, 
> HIVE-22865.3.patch, HIVE-22865.4.patch, HIVE-22865.5.patch, HIVE-22865.6.patch
>
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to