[ https://issues.apache.org/jira/browse/HIVE-22940?focusedWorklogId=396452&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-396452 ]
ASF GitHub Bot logged work on HIVE-22940: ----------------------------------------- Author: ASF GitHub Bot Created on: 02/Mar/20 22:32 Start Date: 02/Mar/20 22:32 Worklog Time Spent: 10m Work Description: jcamachor commented on pull request #930: HIVE-22940 datasketches functions URL: https://github.com/apache/hive/pull/930#discussion_r386684058 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/DataSketchesFunctions.java ########## @@ -0,0 +1,218 @@ +package org.apache.hadoop.hive.ql.exec; + +import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFResolver2; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDTF; + +public class DataSketchesFunctions { + + private static final String DATA_TO_SKETCH = "datatosketch"; + private static final String SKETCH_TO_ESTIMATE_WITH_ERROR_BOUNDS = "sketchToEstimateWithErrorBounds"; + // FIXME: consider to rename it to simply "estimate" or "evaluate" - in case of the counting sketches the "sketchto..." doesnt add value + private static final String SKETCH_TO_ESTIMATE = "sketchToEstimate"; + private static final String SKETCH_TO_STRING = "sketchToString"; + // FIXME: probably use simply "union" instead unionSketch? + private static final String UNION_SKETCH = "unionSketch"; + private static final String GET_N = "getN"; Review comment: Can we use `_` for this function and those below instead of lower-upper case? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 396452) Time Spent: 1h (was: 50m) > Make the datasketches functions available as predefined functions > ------------------------------------------------------------------ > > Key: HIVE-22940 > URL: https://issues.apache.org/jira/browse/HIVE-22940 > Project: Hive > Issue Type: Sub-task > Reporter: Zoltan Haindrich > Assignee: Zoltan Haindrich > Priority: Major > Labels: pull-request-available > Attachments: HIVE-22940.01.patch, HIVE-22940.02.patch > > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)