[ https://issues.apache.org/jira/browse/HIVE-22962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050027#comment-17050027 ]
Hive QA commented on HIVE-22962: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12995382/HIVE-22962.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 13 failed/errored test(s), 18096 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ambiguitycheck] (batchId=85) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cast1] (batchId=87) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[decimal_2] (batchId=72) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_aes_decrypt] (batchId=62) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_aes_encrypt] (batchId=100) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_crc32] (batchId=2) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_decode] (batchId=99) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_md5] (batchId=10) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_sha1] (batchId=8) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_sha2] (batchId=13) org.apache.hadoop.hive.cli.TestKuduCliDriver.testCliDriver[kudu_queries] (batchId=297) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_2] (batchId=175) org.apache.hive.jdbc.TestJdbcWithMiniHS2.testParallelCompilation4 (batchId=293) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/20925/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20925/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20925/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 13 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12995382 - PreCommit-HIVE-Build > Reuse HiveRelFieldTrimmer instance across queries > ------------------------------------------------- > > Key: HIVE-22962 > URL: https://issues.apache.org/jira/browse/HIVE-22962 > Project: Hive > Issue Type: Improvement > Components: CBO > Reporter: Jesus Camacho Rodriguez > Assignee: Jesus Camacho Rodriguez > Priority: Major > Attachments: HIVE-22962.patch > > > Currently we create multiple {{HiveRelFieldTrimmer}} instances per query. > {{HiveRelFieldTrimmer}} uses a method dispatcher that has a built-in caching > mechanism: given a certain object, it stores the method that was called for > the object class. However, by instantiating the trimmer multiple times per > query and across queries, we create a new dispatcher with each instantiation, > thus effectively removing the caching mechanism that is built within the > dispatcher. > This issue is to reutilize the same {{HiveRelFieldTrimmer}} instance within a > single query and across queries. -- This message was sent by Atlassian Jira (v8.3.4#803005)