[
https://issues.apache.org/jira/browse/HIVE-22978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052500#comment-17052500
]
Hive QA commented on HIVE-22978:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12995679/HIVE-22978.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 95 failed/errored test(s), 18101 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[decimal_precision]
(batchId=60)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[decimal_udf] (batchId=10)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_cast_constant]
(batchId=10)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_decimal_aggregate]
(batchId=21)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_decimal_precision]
(batchId=58)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[external_jdbc_table_perf]
(batchId=192)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_scalar]
(batchId=178)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_cast_constant]
(batchId=168)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_aggregate]
(batchId=170)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_precision]
(batchId=181)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_udf]
(batchId=194)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_groupby_grouping_sets3_dec]
(batchId=189)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_scalar]
(batchId=136)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vector_cast_constant]
(batchId=122)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vector_decimal_aggregate]
(batchId=126)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query13]
(batchId=308)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query18]
(batchId=308)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query1]
(batchId=308)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query24]
(batchId=308)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query26]
(batchId=308)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query27]
(batchId=308)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query28]
(batchId=308)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query30]
(batchId=308)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query32]
(batchId=308)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query44]
(batchId=308)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query65]
(batchId=308)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query6]
(batchId=308)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query7]
(batchId=308)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query81]
(batchId=308)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query85]
(batchId=308)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query92]
(batchId=308)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query9]
(batchId=308)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_ext_query1]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query13]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query14]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query18]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query1]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query22]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query24]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query26]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query27]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query28]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query30]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query32]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query65]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query6]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query7]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query81]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query85]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query92]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query9]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query14]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query1]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query1b]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query24]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query30]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query32]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query44]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query65]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query6]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query81]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query85]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query92]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_ext_query1]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query13]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query14]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query18]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query1]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query24]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query26]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query27]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query28]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query30]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query32]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query65]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query6]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query7]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query81]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query85]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query92]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query9]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[mv_query44]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query14]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query1]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query1b]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query24]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query30]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query32]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query44]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query65]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query6]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query81]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query85]
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query92]
(batchId=306)
org.apache.hive.jdbc.TestJdbcGenericUDTFGetSplits.testDecimalPrecisionAndScale
(batchId=291)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/20967/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20967/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20967/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 95 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12995679 - PreCommit-HIVE-Build
> Fix decimal precision and scale inference for aggregate rewriting in Calcite
> ----------------------------------------------------------------------------
>
> Key: HIVE-22978
> URL: https://issues.apache.org/jira/browse/HIVE-22978
> Project: Hive
> Issue Type: Bug
> Components: CBO
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Priority: Major
> Attachments: HIVE-22978.patch
>
>
> Calcite rules can do rewritings of aggregate functions, e.g., {{avg}} into
> {{sum/count}}. When type of {{avg}} is decimal, inference of intermediate
> precision and scale for the division is not done correctly. The reason is
> that we miss support for some types in method {{getDefaultPrecision}} in
> {{HiveTypeSystemImpl}}. Additionally, {{deriveSumType}} should be overridden
> in {{HiveTypeSystemImpl}} to abide by the Hive semantics for sum aggregate
> type inference.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
