[
https://issues.apache.org/jira/browse/HIVE-22959?focusedWorklogId=399284&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-399284
]
ASF GitHub Bot logged work on HIVE-22959:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Mar/20 18:26
Start Date: 06/Mar/20 18:26
Worklog Time Spent: 10m
Work Description: pgaref commented on pull request #931: HIVE-22959
Expose FilterContext as part of Hive storage-api
URL: https://github.com/apache/hive/pull/931#discussion_r389068042
##########
File path:
storage-api/src/java/org/apache/hadoop/hive/ql/io/filter/MutableFilterContext.java
##########
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.ql.io.filter;
+
+import java.util.Arrays;
+
+/**
+ * A representation of a Filter applied on the rows of a VectorizedRowBatch
+ * {@link org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch}.
+ *
+ * Each FilterContext consists of an array with the ids (int) of rows that are
selected by the
+ * filter, an integer representing the number of selected rows, and a boolean
showing if the filter
+ * actually selected any rows.
+ *
+ */
+public class MutableFilterContext extends FilterContext {
+
+ /**
+ * Set context with the given values by reference
+ *
+ * @param isSelectedInUse if the filter is applied
+ * @param selected an array of the selected rows
+ * @param selectedSize the number of the selected rows
+ */
+ public void setFilterContext(boolean isSelectedInUse, int[] selected, int
selectedSize) {
+ this.currBatchIsSelectedInUse = isSelectedInUse;
+ this.currBatchSelected = selected;
+ this.currBatchSelectedSize = selectedSize;
+ // Avoid selected.length < selectedSize since we can borrow a larger array
for selected
+ // debug loop for checking if selected is in order without duplicates (i.e
[1,1,1] is illegal)
+ for (int i = 0; i < selectedSize-1; i++)
+ assert selected[i] < selected[i+1];
Review comment:
Added a separate validate method that is checked with an assertion (the
idea here is to use it only as part of testing)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 399284)
Time Spent: 1h 10m (was: 1h)
> Extend storage-api to expose FilterContext
> ------------------------------------------
>
> Key: HIVE-22959
> URL: https://issues.apache.org/jira/browse/HIVE-22959
> Project: Hive
> Issue Type: Sub-task
> Components: storage-api
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> To enable row-level filtering at the ORC level ORC-577, or as an extension
> ProDecode MapJoin HIVE-22731 we need a common context class that will hold
> all the needed information for the filter.
> I propose this class to be part of the storage-api – similar to
> VectorizedRowBatch class and hold the information below:
> * A boolean variable showing if the filter is enabled
> * A int array storing the row Ids that are actually selected (passing the
> filter)
> * An int variable storing the the number or rows that passed the filter
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
