[
https://issues.apache.org/jira/browse/HIVE-22978?focusedWorklogId=400471&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-400471
]
ASF GitHub Bot logged work on HIVE-22978:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Mar/20 00:25
Start Date: 10/Mar/20 00:25
Worklog Time Spent: 10m
Work Description: vineetgarg02 commented on pull request #938: HIVE-22978
URL: https://github.com/apache/hive/pull/938#discussion_r390027730
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveTypeSystemImpl.java
##########
@@ -148,4 +172,17 @@ public boolean isSchemaCaseSensitive() {
return false;
}
+ @Override
+ public RelDataType deriveSumType(RelDataTypeFactory typeFactory,
Review comment:
Can you add a comment explaining why is this being done? Adding 10 seems
arbitrary without the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 400471)
Time Spent: 0.5h (was: 20m)
> Fix decimal precision and scale inference for aggregate rewriting in Calcite
> ----------------------------------------------------------------------------
>
> Key: HIVE-22978
> URL: https://issues.apache.org/jira/browse/HIVE-22978
> Project: Hive
> Issue Type: Bug
> Components: CBO
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22978.01.patch, HIVE-22978.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Calcite rules can do rewritings of aggregate functions, e.g., {{avg}} into
> {{sum/count}}. When type of {{avg}} is decimal, inference of intermediate
> precision and scale for the division is not done correctly. The reason is
> that we miss support for some types in method {{getDefaultPrecision}} in
> {{HiveTypeSystemImpl}}. Additionally, {{deriveSumType}} should be overridden
> in {{HiveTypeSystemImpl}} to abide by the Hive semantics for sum aggregate
> type inference.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
