[ https://issues.apache.org/jira/browse/HIVE-22997?focusedWorklogId=404393&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-404393 ]
ASF GitHub Bot logged work on HIVE-22997: ----------------------------------------- Author: ASF GitHub Bot Created on: 17/Mar/20 01:42 Start Date: 17/Mar/20 01:42 Worklog Time Spent: 10m Work Description: aasha commented on pull request #951: HIVE-22997 : Copy external table to target during Repl Dump operation URL: https://github.com/apache/hive/pull/951#discussion_r393399950 ########## File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosExternalTables.java ########## @@ -397,17 +397,19 @@ public void externalTableWithPartitions() throws Throwable { primary.run("use " + primaryDbName) .run("insert into table t2 partition(country='france') values ('lyon')") .run("alter table t2 set location '" + tmpLocation2 + "'") - .dump(primaryDbName); + .dump(primaryDbName, withClause); - replica.load(replicatedDbName, primaryDbName, loadWithClause); + replica.load(replicatedDbName, primaryDbName, withClause); assertTablePartitionLocation(primaryDbName + ".t2", replicatedDbName + ".t2"); } @Test public void externalTableIncrementalReplication() throws Throwable { - WarehouseInstance.Tuple tuple = primary.dumpWithCommand("repl dump " + primaryDbName); + List<String> withClause = externalTableBasePathWithClause(); + String replDumpCommand = "repl dump " + primaryDbName + + " WITH (" + withClause.get(0) + "," + withClause.get(1) + ")"; + WarehouseInstance.Tuple tuple = primary.dumpWithCommand(replDumpCommand); Review comment: can use withClause directly ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 404393) Time Spent: 0.5h (was: 20m) > Copy external table to target during Repl Dump operation > -------------------------------------------------------- > > Key: HIVE-22997 > URL: https://issues.apache.org/jira/browse/HIVE-22997 > Project: Hive > Issue Type: Task > Reporter: PRAVIN KUMAR SINHA > Assignee: PRAVIN KUMAR SINHA > Priority: Major > Labels: pull-request-available > Attachments: HIVE-22997.03.patch, HIVE-22997.04.patch, > HIVE-22997.1.patch, HIVE-22997.2.patch, HIVE-22997.4.patch, HIVE-22997.5.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)