[ 
https://issues.apache.org/jira/browse/HIVE-23067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074138#comment-17074138
 ] 

Hive QA commented on HIVE-23067:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12998655/HIVE-23067.5.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21411/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21411/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21411/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit 
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2020-04-02 22:56:46.438
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-21411/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2020-04-02 22:56:46.441
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 7f9ce94 HIVE-23094: Implement Explain CBO of Update and Delete 
statements (Krisztian Kasa, reviewed by Jesus Camacho Rodriguez)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 7f9ce94 HIVE-23094: Implement Explain CBO of Update and Delete 
statements (Krisztian Kasa, reviewed by Jesus Camacho Rodriguez)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2020-04-02 22:56:47.755
+ rm -rf ../yetus_PreCommit-HIVE-Build-21411
+ mkdir ../yetus_PreCommit-HIVE-Build-21411
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-21411
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-21411/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh 
/data/hiveptest/working/scratch/build.patch
Trying to apply the patch with -p0
error: patch failed: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:190
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java'
 with conflicts.
Going to apply patch with: git apply -p0
error: patch failed: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:190
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java'
 with conflicts.
U 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-21411
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12998655 - PreCommit-HIVE-Build

> Use batch DB calls in TxnHandler for commitTxn and abortTxns
> ------------------------------------------------------------
>
>                 Key: HIVE-23067
>                 URL: https://issues.apache.org/jira/browse/HIVE-23067
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Marton Bod
>            Assignee: Marton Bod
>            Priority: Major
>         Attachments: HIVE-23067.1.patch, HIVE-23067.1.patch, 
> HIVE-23067.1.patch, HIVE-23067.1.patch, HIVE-23067.2.patch, 
> HIVE-23067.2.patch, HIVE-23067.4.patch, HIVE-23067.5.patch, 
> HIVE-23067.5.patch, HIVE-23067.5.patch, HIVE-23067.5.patch
>
>
> To reduce the number of database calls and network roundtrips, we could use 
> more batching in TxnHandler, where currently in many places we call insert 
> commands in loops sequentially.
> Some examples:
>  * openTxns (TXNS, REPL_TXN_MAP)
>  * commitTxn (COMPLETED_TXN_COMPONENTS)
>  * replTableWriteIdState (TXN_TO_WRITE_ID)
>  * allocateTableWriteIds (TXN_TO_WRITE_ID)
>  * ....
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to