[
https://issues.apache.org/jira/browse/HIVE-23095?focusedWorklogId=417075&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-417075
]
ASF GitHub Bot logged work on HIVE-23095:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Apr/20 20:06
Start Date: 06/Apr/20 20:06
Worklog Time Spent: 10m
Work Description: prasanthj commented on pull request #964: HIVE-23095
ndv 70
URL: https://github.com/apache/hive/pull/964#discussion_r404355453
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/common/ndv/hll/HLLSparseRegister.java
##########
@@ -148,8 +148,12 @@ public int encodeHash(long hashcode) {
}
}
- public int getSize() {
- return sparseMap.size() + tempListIdx;
+ public boolean isSizeGreaterThan(int s) {
+ if (sparseMap.size() + tempListIdx > s) {
+ mergeTempListToSparseMap();
Review comment:
~130 elements? Did encoding switch threshold change?
Can you please push commit to github PR for easier review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 417075)
Time Spent: 40m (was: 0.5h)
> NDV might be overestimated for a table with ~70 value
> -----------------------------------------------------
>
> Key: HIVE-23095
> URL: https://issues.apache.org/jira/browse/HIVE-23095
> Project: Hive
> Issue Type: Bug
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23095.01.patch, HIVE-23095.02.patch,
> HIVE-23095.03.patch, HIVE-23095.04.patch, HIVE-23095.04.patch,
> HIVE-23095.04.patch, HIVE-23095.05.patch, hll-bench.md
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> uncovered during looking into HIVE-23082
> https://issues.apache.org/jira/browse/HIVE-23082?focusedCommentId=17067773&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17067773
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
