[ 
https://issues.apache.org/jira/browse/HIVE-23227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085421#comment-17085421
 ] 

Jesus Camacho Rodriguez commented on HIVE-23227:
------------------------------------------------

Contract for those functions could be changed too, since many of those methods 
just rewrite children blindly instead of creating the RexNode replacement, 
which would be more interesting and could be easily reused within other rules.

> Refactor RexConverter and move some of its functionality into 
> HiveFunctionHelper
> --------------------------------------------------------------------------------
>
>                 Key: HIVE-23227
>                 URL: https://issues.apache.org/jira/browse/HIVE-23227
>             Project: Hive
>          Issue Type: Improvement
>          Components: CBO
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Major
>
> After HIVE-23100, {{HiveFunctionHelper}} makes a few calls to methods that 
> are in {{RexConverter}}. Those methods do not need to be there anymore but 
> were not moved as part of that patch to avoid further changes in it. This 
> issue is to tackle that refactoring.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to