[ https://issues.apache.org/jira/browse/HIVE-23117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086016#comment-17086016 ]
Peter Vary commented on HIVE-23117: ----------------------------------- [~belugabehr]: Two questions: * As on another jira, here I do not understand the added value of using Optional? Another reference for a case where we can use a null check? * There is a typo "FAiled" Thanks, Peter > Review of HiveStatement Class > ----------------------------- > > Key: HIVE-23117 > URL: https://issues.apache.org/jira/browse/HIVE-23117 > Project: Hive > Issue Type: Improvement > Components: JDBC > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Minor > Attachments: HIVE-23117.1.patch > > > * Remove unused instance variable(s) > * Remove non-JavaDoc comments > * Make inPlaceUpdateStream Optional (and remove NO-OP class) (inconsistent > behavior with 'null' values) > * {{getQueryTimeout()}} returns incorrect value > * Unify and improve Exception messages > * Checkstyle fixes -- This message was sent by Atlassian Jira (v8.3.4#803005)