[
https://issues.apache.org/jira/browse/HIVE-22750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086998#comment-17086998
]
Denys Kuzmenko commented on HIVE-22750:
---------------------------------------
[~abstractdog], [~Marton Bod], I've addressed ASF & bunch of other checkstyle
violations in [HIVE-19369|https://issues.apache.org/jira/browse/HIVE-19369]
> Consolidate LockType naming
> ---------------------------
>
> Key: HIVE-22750
> URL: https://issues.apache.org/jira/browse/HIVE-22750
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
> Reporter: Zoltan Chovan
> Assignee: Marton Bod
> Priority: Minor
> Attachments: HIVE-22750.1.patch, HIVE-22750.10.patch,
> HIVE-22750.11.patch, HIVE-22750.12.patch, HIVE-22750.12.patch,
> HIVE-22750.13.patch, HIVE-22750.2.patch, HIVE-22750.3.patch,
> HIVE-22750.4.patch, HIVE-22750.5.patch, HIVE-22750.5.patch,
> HIVE-22750.6.patch, HIVE-22750.7.patch, HIVE-22750.8.patch,
> HIVE-22750.9.patch, HIVE-22750.9.patch, HIVE-22750.9.patch, HIVE-22750.9.patch
>
>
> Extend enum with string literal to remove unnecessary `id` to `char` casting
> for the LockType:
> {code:java}
> switch (lockType) {
> case EXCLUSIVE:
> lockChar = LOCK_EXCLUSIVE;
> break;
> case SHARED_READ:
> lockChar = LOCK_SHARED;
> break;
> case SHARED_WRITE:
> lockChar = LOCK_SEMI_SHARED;
> break;
> }
> {code}
> Consolidate LockType naming in code and schema upgrade scripts:
> {code:java}
> CASE WHEN HL.`HL_LOCK_TYPE` = 'e' THEN 'exclusive' WHEN HL.`HL_LOCK_TYPE` =
> 'r' THEN 'shared' WHEN HL.`HL_LOCK_TYPE` = 'w' THEN *'semi-shared'* END AS
> LOCK_TYPE,
> {code}
> +*Lock types:*+
> EXCLUSIVE
> EXCL_WRITE
> SHARED_WRITE
> SHARED_READ
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
