[
https://issues.apache.org/jira/browse/HIVE-23215?focusedWorklogId=425404&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425404
]
ASF GitHub Bot logged work on HIVE-23215:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/20 18:09
Start Date: 20/Apr/20 18:09
Worklog Time Spent: 10m
Work Description: omalley commented on issue #983:
URL: https://github.com/apache/hive/pull/983#issuecomment-616722525
This seems to work well when I was working with the filters for ORC-577. A
couple of comments:
* It feels a little worrisome letting the user pass in a selection array and
they never know the right length without calling getSelectionSize first.
* We probably don't need the separate setSelectedInUser and setSelectedSize.
All of the filters would just call setFilterContext to set both in a single
call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 425404)
Time Spent: 1h 20m (was: 1h 10m)
> Make FilterContext and MutableFilterContext interfaces
> ------------------------------------------------------
>
> Key: HIVE-23215
> URL: https://issues.apache.org/jira/browse/HIVE-23215
> Project: Hive
> Issue Type: Bug
> Components: storage-api
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23215.patch
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> HIVE-22959 introduced FilterContext to support ORC-577. The duplication of
> fields between the FilterContext and VectorizedRowBatch seems likely to cause
> user confusion. This patch makes them interfaces that VectorizedRowBatch
> implements.
> Thus, there is a single copy of the data and no need to copy them back and
> forth. LLAP can make its own implementation of the interfaces if it doesn't
> want to use VectorizedRowBatch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
