[ https://issues.apache.org/jira/browse/HIVE-23124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096464#comment-17096464 ]
Hive QA commented on HIVE-23124: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13001594/HIVE-23124.3.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17177 tests executed *Failed tests:* {noformat} TestStatsReplicationScenariosACID - did not produce a TEST-*.xml file (likely timed out) (batchId=184) org.apache.hive.jdbc.TestJdbcGenericUDTFGetSplits2.testGenericUDTFOrderBySplitCount1 (batchId=212) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22032/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22032/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22032/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13001594 - PreCommit-HIVE-Build > Review of SQLOperation Class > ---------------------------- > > Key: HIVE-23124 > URL: https://issues.apache.org/jira/browse/HIVE-23124 > Project: Hive > Issue Type: Improvement > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Major > Attachments: HIVE-23124.1.patch, HIVE-23124.2.patch, > HIVE-23124.3.patch, HIVE-23124.3.patch > > > * Use ConcurrentHashMap instead of synchronized methods to improve > multi-threaded access > * Use JDK 8 facilities where applicable > * General cleanup > * Better log messages and Exception messages > * Use {{switch}} statement instead of if/else blocks > * Checkstyle fixes -- This message was sent by Atlassian Jira (v8.3.4#803005)