[ https://issues.apache.org/jira/browse/HIVE-23266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097681#comment-17097681 ]
Hive QA commented on HIVE-23266: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13001786/HIVE-23266.7.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 17195 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.metastore.TestGetPartitionsUsingProjectionAndFilterSpecs.testGetPartitions (batchId=156) org.apache.hadoop.hive.metastore.TestGetPartitionsUsingProjectionAndFilterSpecs.testPartitionProjectionEmptySpec (batchId=156) org.apache.hadoop.hive.metastore.TestObjectStore.testDirectSQLDropPartitionsCacheCrossSession (batchId=163) org.apache.hadoop.hive.metastore.TestObjectStore.testDirectSQLDropPartitionsCacheInSession (batchId=163) org.apache.hadoop.hive.metastore.tools.metatool.TestHiveMetaTool.testExecuteJDOQL (batchId=174) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22062/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22062/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22062/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 5 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13001786 - PreCommit-HIVE-Build > Remove QueryWrapper from ObjectStore > ------------------------------------ > > Key: HIVE-23266 > URL: https://issues.apache.org/jira/browse/HIVE-23266 > Project: Hive > Issue Type: Improvement > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Major > Attachments: HIVE-23266.1.patch, HIVE-23266.2.patch, > HIVE-23266.2.patch, HIVE-23266.3.patch, HIVE-23266.4.patch, > HIVE-23266.5.patch, HIVE-23266.6.patch, HIVE-23266.7.patch > > > There is currently a utility called {{QueryWrapper}} that makes a normal > {{Query}} auto-closable. However, {{Query}} is now in fact already > auto-closing, so there is no need for this class. In trying to remove it, I > realized that this wrapper was being passed around in pretty convoluted ways > and also it was sometimes being created in a {{try-with-resources}} block but > then never actually used in any way. > Remove the {{QueryWrapper}} from the class and simplify some of the DB > interactions. > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L178 -- This message was sent by Atlassian Jira (v8.3.4#803005)