[ https://issues.apache.org/jira/browse/HIVE-23099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104658#comment-17104658 ]
Hive QA commented on HIVE-23099: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13002634/HIVE-23099.4.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 17253 tests executed *Failed tests:* {noformat} org.apache.hive.jdbc.TestJdbcWithMiniLlapRow.testComplexQuery (batchId=215) org.apache.hive.jdbc.TestJdbcWithMiniLlapRow.testDataTypes (batchId=215) org.apache.hive.jdbc.TestJdbcWithMiniLlapRow.testEscapedStrings (batchId=215) org.apache.hive.jdbc.TestJdbcWithMiniLlapRow.testInvalidReferenceCountScenario (batchId=215) org.apache.hive.jdbc.TestJdbcWithMiniLlapRow.testKillQuery (batchId=215) org.apache.hive.jdbc.TestJdbcWithMiniLlapRow.testLlapInputFormatEndToEnd (batchId=215) org.apache.hive.jdbc.TestJdbcWithMiniLlapRow.testLlapInputFormatEndToEndWithMultipleBatches (batchId=215) org.apache.hive.jdbc.TestJdbcWithMiniLlapRow.testMultipleBatchesOfComplexTypes (batchId=215) org.apache.hive.jdbc.TestJdbcWithMiniLlapRow.testNonAsciiStrings (batchId=215) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22268/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22268/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22268/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 9 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13002634 - PreCommit-HIVE-Build > Improve Logger for Operation Child Classes > ------------------------------------------ > > Key: HIVE-23099 > URL: https://issues.apache.org/jira/browse/HIVE-23099 > Project: Hive > Issue Type: Improvement > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Minor > Attachments: HIVE-23099.1.patch, HIVE-23099.2.patch, > HIVE-23099.3.patch, HIVE-23099.4.patch, HIVE-23099.4.patch, HIVE-23099.4.patch > > > The {{Operation}} class declares its logger this way: > {code:java|title=Operation.java} > public abstract class Operation { > public static final Logger LOG = > LoggerFactory.getLogger(Operation.class.getName()); > ... > } > {code} > Notice that this is an {{abstract}} class, but the {{Logger}} is tied to the > {{Operation.class.getName()}}. This means that logging cannot be controlled > for each subclass of {{Operation}} independently since they all use the same > static {{Logger}} instance. > Make the LOG a {{protected}} instance variable that inherits the name of the > child class. -- This message was sent by Atlassian Jira (v8.3.4#803005)