[ 
https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110845#comment-17110845
 ] 

Hive QA commented on HIVE-23017:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13003313/HIVE-23017.6.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 17269 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.metastore.txn.TestTxnHandler.testReplTimeouts 
(batchId=247)
org.apache.hive.beeline.TestBeeLineWithArgs.testEmbeddedBeelineOutputs 
(batchId=211)
org.apache.hive.service.cli.operation.TestOperationLoggingAPIWithMr.testFetchResultsOfLogWithExecutionMode
 (batchId=214)
org.apache.hive.service.cli.operation.TestOperationLoggingAPIWithMr.testFetchResultsOfLogWithPerformanceMode
 (batchId=214)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/22448/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22448/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22448/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13003313 - PreCommit-HIVE-Build

> Use Inherited Logger in Tasks
> -----------------------------
>
>                 Key: HIVE-23017
>                 URL: https://issues.apache.org/jira/browse/HIVE-23017
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>         Attachments: HIVE-23017.1.patch, HIVE-23017.2.patch, 
> HIVE-23017.3.patch, HIVE-23017.4.patch, HIVE-23017.5.patch, 
> HIVE-23017.6.patch, HIVE-23017.6.patch
>
>
> {code:java|title=FetchTask}
> public class FetchTask extends Task<FetchWork> implements Serializable {
>   private static final long serialVersionUID = 1L;
>   private int maxRows = 100;
>   private FetchOperator fetch;
>   private ListSinkOperator sink;
>   private int totalRows;
>   private static transient final Logger LOG = 
> LoggerFactory.getLogger(FetchTask.class);
>   JobConf job = null;
> {code}
> The Tasks class is base class for many other.  Cleaner to simply make the 
> {{Logger}} {{protected}} and usable by other classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to