[ https://issues.apache.org/jira/browse/HIVE-23495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110905#comment-17110905 ]
Hive QA commented on HIVE-23495: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13003318/HIVE-23495.1.patch {color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 21 failed/errored test(s), 17268 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[mm_all] (batchId=27) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[mm_exim] (batchId=124) org.apache.hadoop.hive.ql.TestTxnCommands.testMmExim (batchId=301) org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion1 (batchId=274) org.apache.hadoop.hive.ql.TestTxnCommands2.updateDeletePartitioned (batchId=274) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testNonAcidToAcidConversion1 (batchId=297) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.updateDeletePartitioned (batchId=297) org.apache.hadoop.hive.ql.TestTxnCommandsForMmTable.testInsertOverwriteForPartitionedMmTable (batchId=247) org.apache.hadoop.hive.ql.TestTxnCommandsForMmTable.testInsertOverwriteWithUnionAll (batchId=247) org.apache.hadoop.hive.ql.TestTxnCommandsForOrcMmTable.testInsertOverwriteForPartitionedMmTable (batchId=271) org.apache.hadoop.hive.ql.TestTxnCommandsForOrcMmTable.testInsertOverwriteWithUnionAll (batchId=271) org.apache.hadoop.hive.ql.TestTxnCommandsWithSplitUpdateAndVectorization.testMmExim (batchId=277) org.apache.hadoop.hive.ql.TestTxnExIm.testMM (batchId=278) org.apache.hadoop.hive.ql.TestTxnExIm.testMMCreate (batchId=278) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testDumpAcidTableWithPartitionDirMissing (batchId=202) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testDumpAcidTableWithTableDirMissing (batchId=202) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testMultiDBTxn (batchId=202) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testDumpAcidTableWithPartitionDirMissing (batchId=204) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testDumpAcidTableWithTableDirMissing (batchId=204) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testMultiDBTxn (batchId=204) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosIncrementalLoadAcidTables.testAcidTableIncrementalReplication (batchId=205) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22451/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22451/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22451/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 21 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13003318 - PreCommit-HIVE-Build > AcidUtils.getAcidState cleanup > ------------------------------ > > Key: HIVE-23495 > URL: https://issues.apache.org/jira/browse/HIVE-23495 > Project: Hive > Issue Type: Improvement > Reporter: Peter Varga > Assignee: Peter Varga > Priority: Major > Attachments: HIVE-23495.1.patch > > > since HIVE-21225 there are two redundant implementation of the > AcidUtils.getAcidState. > The previous implementation (without the recursive listing) can be removed. > Also the performance can be improved, by removing unnecessary fileStatus > calls. -- This message was sent by Atlassian Jira (v8.3.4#803005)