[ 
https://issues.apache.org/jira/browse/HIVE-23214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110954#comment-17110954
 ] 

Hive QA commented on HIVE-23214:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13003324/HIVE-23214.02.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17269 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/22452/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22452/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22452/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13003324 - PreCommit-HIVE-Build

> Remove skipCorrupt from OrcEncodedDataConsumer
> ----------------------------------------------
>
>                 Key: HIVE-23214
>                 URL: https://issues.apache.org/jira/browse/HIVE-23214
>             Project: Hive
>          Issue Type: Improvement
>          Components: llap
>            Reporter: Panagiotis Garefalakis
>            Assignee: Panagiotis Garefalakis
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: HIVE-23214.01.patch, HIVE-23214.02.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> SkipCorrupt is always the default (false) so there is no reason to pass it 
> around.
> [https://github.com/apache/hive/blob/3e4f6122c32b1ffa22e1458806ae8ee30e51a41f/llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java#L86]
> If we want to change the default behaviour we could set 
> "orc.skip.corrupt.data" as part of the configuration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to