[
https://issues.apache.org/jira/browse/HIVE-22017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112847#comment-17112847
]
Hive QA commented on HIVE-22017:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13003572/HIVE-216371.1.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/22513/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22513/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22513/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2020-05-21 06:49:17.807
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-22513/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2020-05-21 06:49:17.810
+ cd apache-github-source-source
+ git fetch origin
>From https://github.com/apache/hive
19cc2a1..04b311d master -> origin/master
+ git reset --hard HEAD
HEAD is now at 19cc2a1 HIVE-22458: Add more constraints on showing partitions
(Zhihua Deng, reviewed by Miklos Gergely)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is behind 'origin/master' by 1 commit, and can be fast-forwarded.
(use "git pull" to update your local branch)
+ git reset --hard origin/master
HEAD is now at 04b311d HIVE-23501 : AOOB in VectorDeserializeRow when complex
types are converted to primitive types (Ramesh Kumar via Ashutosh Chauhan)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2020-05-21 06:49:19.813
+ rm -rf ../yetus_PreCommit-HIVE-Build-22513
+ mkdir ../yetus_PreCommit-HIVE-Build-22513
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-22513
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-22513/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
Trying to apply the patch with -p0
error: patch failed:
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsByExprRequest.java:44
Falling back to three-way merge...
Applied patch to
'standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsByExprRequest.java'
with conflicts.
error: patch failed:
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java:126348
Falling back to three-way merge...
Applied patch to
'standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java'
with conflicts.
error: patch failed:
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php:35409
Falling back to three-way merge...
Applied patch to
'standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php'
with conflicts.
error: patch failed:
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py:30766
Falling back to three-way merge...
Applied patch to
'standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py'
with conflicts.
error: patch failed:
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py:10078
Falling back to three-way merge...
Applied patch to
'standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py'
with conflicts.
error: patch failed:
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb:2276
Falling back to three-way merge...
Applied patch to
'standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb'
with conflicts.
error: patch failed:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:773
Falling back to three-way merge...
Applied patch to
'standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift'
with conflicts.
Going to apply patch with: git apply -p0
/data/hiveptest/working/scratch/build.patch:145: trailing whitespace.
tmpMap.put(_Fields.DB_NAME, new
org.apache.thrift.meta_data.FieldMetaData("dbName",
org.apache.thrift.TFieldRequirementType.REQUIRED,
/data/hiveptest/working/scratch/build.patch:147: trailing whitespace.
tmpMap.put(_Fields.TBL_NAME, new
org.apache.thrift.meta_data.FieldMetaData("tblName",
org.apache.thrift.TFieldRequirementType.REQUIRED,
/data/hiveptest/working/scratch/build.patch:149: trailing whitespace.
tmpMap.put(_Fields.VALID_WRITE_ID_LIST, new
org.apache.thrift.meta_data.FieldMetaData("validWriteIdList",
org.apache.thrift.TFieldRequirementType.OPTIONAL,
/data/hiveptest/working/scratch/build.patch:518: trailing whitespace.
if (schemeField.type == org.apache.thrift.protocol.TType.STOP) {
/data/hiveptest/working/scratch/build.patch:526: trailing whitespace.
} else {
error: patch failed:
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsByExprRequest.java:44
Falling back to three-way merge...
Applied patch to
'standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsByExprRequest.java'
with conflicts.
error: patch failed:
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java:126348
Falling back to three-way merge...
Applied patch to
'standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java'
with conflicts.
error: patch failed:
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php:35409
Falling back to three-way merge...
Applied patch to
'standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php'
with conflicts.
error: patch failed:
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py:30766
Falling back to three-way merge...
Applied patch to
'standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py'
with conflicts.
error: patch failed:
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py:10078
Falling back to three-way merge...
Applied patch to
'standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py'
with conflicts.
error: patch failed:
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb:2276
Falling back to three-way merge...
Applied patch to
'standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb'
with conflicts.
error: patch failed:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:773
Falling back to three-way merge...
Applied patch to
'standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift'
with conflicts.
U
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsByExprRequest.java
U
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
U
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php
U
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py
U
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py
U
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb
U standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
warning: squelched 222 whitespace errors
warning: 227 lines add whitespace errors.
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-22513
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 13003572 - PreCommit-HIVE-Build
> Keep HMS interfaces backward compatible with changes for HIVE-21637
> -------------------------------------------------------------------
>
> Key: HIVE-22017
> URL: https://issues.apache.org/jira/browse/HIVE-22017
> Project: Hive
> Issue Type: Sub-task
> Affects Versions: 2.3.7
> Reporter: Daniel Dai
> Assignee: Kishen Das
> Priority: Major
> Attachments: HIVE-216371.1.patch
>
>
> As part of HIVE-21637 we would have to introduce ValidWriteIdList in several
> methods. Also, in the long term, we should deprecate and remove all the
> methods that take direct arguments, as the service definition keeps changing
> whenever we add/remove arguments, making it hard to maintain backward
> compatibility. So, instead of adding writeId in bunch of get_xxx calls that
> take direct arguments, we will create new set of methods that take Request
> object and return Response object. We shall mark those deprecated and remove
> in future version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
