[ https://issues.apache.org/jira/browse/HIVE-23527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114386#comment-17114386 ]
Hive QA commented on HIVE-23527: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13003718/HIVE-23527.01.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 32 failed/errored test(s), 17281 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cbo_rp_windowing] (batchId=71) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cbo_rp_windowing_2] (batchId=58) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[join46] (batchId=31) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_in] (batchId=96) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_notin] (batchId=103) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_unqualcolumnrefs] (batchId=48) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[topnkey_windowing] (batchId=57) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[topnkey_windowing_order] (batchId=48) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_rank] (batchId=90) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_streaming] (batchId=84) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[windowing_filter] (batchId=79) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[windowing_streaming] (batchId=100) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query47] (batchId=231) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query49] (batchId=231) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query57] (batchId=231) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query44] (batchId=231) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query47] (batchId=231) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query49] (batchId=231) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query57] (batchId=231) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query67] (batchId=231) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query70] (batchId=231) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query47] (batchId=230) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query49] (batchId=230) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query57] (batchId=230) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[mv_query44] (batchId=230) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[mv_query67] (batchId=230) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query44] (batchId=230) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query47] (batchId=230) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query49] (batchId=230) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query57] (batchId=230) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query67] (batchId=230) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query70] (batchId=230) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22550/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22550/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22550/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 32 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13003718 - PreCommit-HIVE-Build > CUME_DIST should be threated as a function returning double > ----------------------------------------------------------- > > Key: HIVE-23527 > URL: https://issues.apache.org/jira/browse/HIVE-23527 > Project: Hive > Issue Type: Bug > Reporter: Zoltan Haindrich > Assignee: Zoltan Haindrich > Priority: Major > Attachments: HIVE-23527.01.patch, HIVE-23527.01.patch > > > right now it is handled as integer in calcite - which might cause some > trouble (at least for me) > Interestingly enough it seems like only percent_rank has double type > https://github.com/apache/hive/blob/b047cfae872244e769f5d1c3c11811d1c49c19ad/ql/src/java/org/apache/hadoop/hive/ql/parse/type/HiveFunctionHelper.java#L392 > since this change goes back to HIVE-9133 and seems to me that removing this > tweak is just works - I'll submit a patch to remove this conditional -- This message was sent by Atlassian Jira (v8.3.4#803005)