[ 
https://issues.apache.org/jira/browse/HIVE-22017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119507#comment-17119507
 ] 

Hive QA commented on HIVE-22017:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13004327/HIVE-22017.1.patch

{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 15 failed/errored test(s), 17318 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionReq[Embedded]
 (batchId=156)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionReq[Remote]
 (batchId=156)
org.apache.hadoop.hive.metastore.client.TestListPartitions.testGetPartitionsRequestWithArgs[Embedded]
 (batchId=154)
org.apache.hadoop.hive.metastore.client.TestListPartitions.testGetPartitionsRequestWithArgs[Remote]
 (batchId=154)
org.apache.hadoop.hive.ql.metadata.TestSessionHiveMetastoreClientGetPartitionsTempTable.testGetPartitionReq[Embedded]
 (batchId=270)
org.apache.hadoop.hive.ql.metadata.TestSessionHiveMetastoreClientGetPartitionsTempTable.testGetPartitionReq[Remote]
 (batchId=270)
org.apache.hadoop.hive.ql.metadata.TestSessionHiveMetastoreClientListPartitionsTempTable.testGetPartitionsRequestWithArgs[Embedded]
 (batchId=270)
org.apache.hadoop.hive.ql.metadata.TestSessionHiveMetastoreClientListPartitionsTempTable.testGetPartitionsRequestWithArgs[Remote]
 (batchId=270)
org.apache.hadoop.hive.ql.metadata.TestSessionHiveMetastoreClientListPartitionsTempTable.testGetPartitionsRequest[Embedded]
 (batchId=270)
org.apache.hadoop.hive.ql.metadata.TestSessionHiveMetastoreClientListPartitionsTempTable.testGetPartitionsRequest[Remote]
 (batchId=270)
org.apache.hadoop.hive.ql.metadata.TestSessionHiveMetastoreClientListPartitionsTempTable.testListPartitionNamesRequestByValues[Embedded]
 (batchId=270)
org.apache.hadoop.hive.ql.metadata.TestSessionHiveMetastoreClientListPartitionsTempTable.testListPartitionNamesRequestByValues[Remote]
 (batchId=270)
org.apache.hadoop.hive.ql.metadata.TestSessionHiveMetastoreClientListPartitionsTempTable.testListPartitionsWithAuthRequestByValues[Embedded]
 (batchId=270)
org.apache.hadoop.hive.ql.metadata.TestSessionHiveMetastoreClientListPartitionsTempTable.testListPartitionsWithAuthRequestByValues[Remote]
 (batchId=270)
org.apache.hadoop.hive.ql.stats.TestStatsUpdaterThread.testTxnTable 
(batchId=258)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/22684/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22684/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22684/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 15 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13004327 - PreCommit-HIVE-Build

> [ Interface changes ] Keep HMS interfaces backward compatible with changes 
> for HIVE-21637
> -----------------------------------------------------------------------------------------
>
>                 Key: HIVE-22017
>                 URL: https://issues.apache.org/jira/browse/HIVE-22017
>             Project: Hive
>          Issue Type: Sub-task
>    Affects Versions: 2.3.7
>            Reporter: Daniel Dai
>            Assignee: Kishen Das
>            Priority: Major
>         Attachments: HIVE-216371.1.patch, HIVE-216371.2.patch, 
> HIVE-22017.1.patch
>
>
> As part of HIVE-21637 we would have to introduce ValidWriteIdList in several 
> methods. Also, in the long term, we should deprecate and remove all the 
> methods that take direct arguments, as the service definition keeps changing 
> whenever we add/remove arguments, making it hard to maintain backward 
> compatibility. So, instead of adding writeId  in bunch of get_xxx calls that 
> take direct arguments, we will create new set of methods that take Request 
> object and return Response object. We shall mark those deprecated and remove 
> in future version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to