[
https://issues.apache.org/jira/browse/HIVE-23514?focusedWorklogId=438735&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-438735
]
ASF GitHub Bot logged work on HIVE-23514:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/20 13:22
Start Date: 29/May/20 13:22
Worklog Time Spent: 10m
Work Description: aasha commented on a change in pull request #1040:
URL: https://github.com/apache/hive/pull/1040#discussion_r432476084
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java
##########
@@ -73,7 +74,12 @@ public int execute() {
String entityGuid = checkHiveEntityGuid(atlasRequestBuilder,
atlasReplInfo.getSrcCluster(),
atlasReplInfo.getSrcDB());
long currentModifiedTime = getCurrentTimestamp(atlasReplInfo,
entityGuid);
- dumpAtlasMetaData(atlasRequestBuilder, atlasReplInfo);
+ AtlasDumpLogger replLogger = new
AtlasDumpLogger(atlasReplInfo.getSrcDB(),
+ atlasReplInfo.getStagingDir().toString());
+ replLogger.startLog();
Review comment:
start should be called when the atlas dump task starts. This will give
the complete estimate of time taken.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasLoadTask.java
##########
@@ -66,7 +72,7 @@ public int execute() {
}
}
- private AtlasReplInfo createAtlasReplInfo() throws SemanticException,
MalformedURLException {
+ public AtlasReplInfo createAtlasReplInfo() throws SemanticException,
MalformedURLException {
Review comment:
Do you need this to be public?
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java
##########
@@ -73,7 +74,12 @@ public int execute() {
String entityGuid = checkHiveEntityGuid(atlasRequestBuilder,
atlasReplInfo.getSrcCluster(),
atlasReplInfo.getSrcDB());
long currentModifiedTime = getCurrentTimestamp(atlasReplInfo,
entityGuid);
- dumpAtlasMetaData(atlasRequestBuilder, atlasReplInfo);
+ AtlasDumpLogger replLogger = new
AtlasDumpLogger(atlasReplInfo.getSrcDB(),
+ atlasReplInfo.getStagingDir().toString());
+ replLogger.startLog();
+ long numBytesWritten = dumpAtlasMetaData(atlasRequestBuilder,
atlasReplInfo);
+ LOG.debug("Finished dumping atlas metadata, total:{} bytes written",
numBytesWritten);
+ replLogger.endLog(0L);
Review comment:
Do you want to send 0 or send the bytes written? Not sure how useful
that is though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 438735)
Time Spent: 20m (was: 10m)
> Add Atlas metadata replication metrics
> --------------------------------------
>
> Key: HIVE-23514
> URL: https://issues.apache.org/jira/browse/HIVE-23514
> Project: Hive
> Issue Type: Task
> Reporter: Pravin Sinha
> Assignee: Pravin Sinha
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23514.01.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
