[
https://issues.apache.org/jira/browse/HIVE-23533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124755#comment-17124755
]
Hive QA commented on HIVE-23533:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13004683/HIVE-23533.02.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17094 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/22724/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22724/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22724/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 13004683 - PreCommit-HIVE-Build
> Remove an FS#exists call from AcidUtils#getLogicalLength
> --------------------------------------------------------
>
> Key: HIVE-23533
> URL: https://issues.apache.org/jira/browse/HIVE-23533
> Project: Hive
> Issue Type: Improvement
> Reporter: Karen Coppage
> Assignee: Karen Coppage
> Priority: Major
> Attachments: HIVE-23533.01.patch, HIVE-23533.01.patch,
> HIVE-23533.01.patch, HIVE-23533.02.patch
>
>
> {code:java}
> Path lengths = OrcAcidUtils.getSideFile(file.getPath());
> if(!fs.exists(lengths)) {
> ...
> return file.getLen();
> }
> long len = OrcAcidUtils.getLastFlushLength(fs, file.getPath());
> {code}
> OrcAcidUtils.getLastFlushLength also has an exists() check and returns
> Long.MAX_VALUE if false.
> exists() is expensive on S3.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
