[ 
https://issues.apache.org/jira/browse/HIVE-23026?focusedWorklogId=440833&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440833
 ]

ASF GitHub Bot logged work on HIVE-23026:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Jun/20 15:21
            Start Date: 03/Jun/20 15:21
    Worklog Time Spent: 10m 
      Work Description: belugabehr commented on a change in pull request #947:
URL: https://github.com/apache/hive/pull/947#discussion_r434641680



##########
File path: .travis.yml
##########
@@ -42,4 +42,4 @@ before_install:
 
 install: true
 
-script: travis_wait 30 mvn clean install -DskipTests -T 4 -q -Pitests
+script: mvn clean install -DskipTests -q -Pitests

Review comment:
       Not related to this task.  Please remove.

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
##########
@@ -310,7 +311,11 @@ protected void openInternal(final HiveConf conf, 
Collection<String> additionalFi
 
     setupSessionAcls(tezConfig, conf);
 
-    final TezClient session = TezClient.newBuilder("HIVE-" + sessionId, 
tezConfig)
+    String tezJobName = HiveConf.getVar(conf,ConfVars.HIVETEZJOBNAME); 
+    if (StringUtils.isBlank(tezJobName)){
+      tezJobName = "HIVE-" + sessionId;

Review comment:
       What is the value of setting a hard coded name here?
   
   I think it would be more useful if it would accept a Format String:
   
   `
   tezJobName = String.format("HIVE-%s", sessionId);
   `
   
   The default value of the configuration should be `HIVE-%s`

##########
File path: .travis.yml
##########
@@ -33,7 +33,7 @@ cache:
 
 env:
   MAVEN_SKIP_RC=true
-  MAVEN_OPTS="-Xmx2g -XX:MaxPermSize=512M"

Review comment:
       Not related to this task.  Please remove.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 440833)
    Remaining Estimate: 0h
            Time Spent: 10m

> Support add a yarn application name for tez on hiveserver2
> ----------------------------------------------------------
>
>                 Key: HIVE-23026
>                 URL: https://issues.apache.org/jira/browse/HIVE-23026
>             Project: Hive
>          Issue Type: Improvement
>          Components: Tez
>    Affects Versions: 2.3.5
>            Reporter: Jake Xie
>            Priority: Major
>             Fix For: 2.3.5
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently tez on hiveServer2 cannot specify yarn application name, which is 
> not very convenient for locating the problem SQL, so i added a configuration 
> item to support setting tez job name



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to