[
https://issues.apache.org/jira/browse/HIVE-21895?focusedWorklogId=440873&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440873
]
ASF GitHub Bot logged work on HIVE-21895:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jun/20 16:38
Start Date: 03/Jun/20 16:38
Worklog Time Spent: 10m
Work Description: belugabehr commented on pull request #680:
URL: https://github.com/apache/hive/pull/680#issuecomment-638314315
Can you please take another crack at this?
Also, be mindful of this situation:
`
LOG.info("Flushing Kafka Producer with writerId [{}]", writerId);
producer.flush();
LOG.info("Closing WriterId [{}]", writerId);
producer.close();
`
I think the 'flush' should be wrapped in a try-finally block with the close.
Right now, if the flush fails, the close is skipped.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 440873)
Time Spent: 20m (was: 10m)
> Kafka Storage handler uses deprecated Kafka client methods
> ----------------------------------------------------------
>
> Key: HIVE-21895
> URL: https://issues.apache.org/jira/browse/HIVE-21895
> Project: Hive
> Issue Type: Improvement
> Components: kafka integration
> Affects Versions: 4.0.0
> Reporter: Kristopher Kane
> Assignee: Kristopher Kane
> Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-21895.1.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The Kafka client version is 2.2 and there are deprecated methods used like
> {code:java}
> producer.close(0, TimeUnit){code}
> in SimpleKafkaWriter
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
