[ https://issues.apache.org/jira/browse/HIVE-23266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128515#comment-17128515 ]
David Mollitor commented on HIVE-23266: --------------------------------------- Good catch on the RuntimeException. I've updated the PR to make this a bit cleaner. The problem was rooted in the fact that {{convertToParts}} throws a {{MetaException}} but {{listMPartitionsWithProjection}} throws a plain old {{Exception}}. > Remove QueryWrapper from ObjectStore > ------------------------------------ > > Key: HIVE-23266 > URL: https://issues.apache.org/jira/browse/HIVE-23266 > Project: Hive > Issue Type: Improvement > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Major > Attachments: HIVE-23266.1.patch, HIVE-23266.10.patch, > HIVE-23266.11.patch, HIVE-23266.2.patch, HIVE-23266.2.patch, > HIVE-23266.3.patch, HIVE-23266.4.patch, HIVE-23266.5.patch, > HIVE-23266.6.patch, HIVE-23266.7.patch, HIVE-23266.8.patch, HIVE-23266.9.patch > > > There is currently a utility called {{QueryWrapper}} that makes a normal > {{Query}} auto-closable. However, {{Query}} is now in fact already > auto-closing, so there is no need for this class. In trying to remove it, I > realized that this wrapper was being passed around in pretty convoluted ways > and also it was sometimes being created in a {{try-with-resources}} block but > then never actually used in any way. > Remove the {{QueryWrapper}} from the class and simplify some of the DB > interactions. > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L178 -- This message was sent by Atlassian Jira (v8.3.4#803005)