[
https://issues.apache.org/jira/browse/HIVE-23561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129119#comment-17129119
]
mahesh kumar behera commented on HIVE-23561:
--------------------------------------------
+1
Looks good to me.
> FIX Arrow Decimal serialization for native VectorRowBatches
> -----------------------------------------------------------
>
> Key: HIVE-23561
> URL: https://issues.apache.org/jira/browse/HIVE-23561
> Project: Hive
> Issue Type: Bug
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Attachments: HIVE-23561.01.patch
>
>
> Arrow Serializer does not properly handle Decimal primitive values when
> selected array is used.
> In more detail, decimalValueSetter should be setting the value at
> *arrowIndex[i]* as the value at *hiveIndex[j]*, however currently its using
> the _same_ index!
> https://github.com/apache/hive/blob/eac25e711ea750bc52f41da7ed3c32bfe36d4f67/ql/src/java/org/apache/hadoop/hive/ql/io/arrow/Serializer.java#L926
> This works fine for cases where i == j (selected is not used) but returns
> wrong decimal row values when i != j.
> This ticket fixes this inconsistency and adds tests with selected indexes for
> all supported types
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
