[
https://issues.apache.org/jira/browse/HIVE-23659?focusedWorklogId=443568&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443568
]
ASF GitHub Bot logged work on HIVE-23659:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/20 05:35
Start Date: 10/Jun/20 05:35
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #1086:
URL: https://github.com/apache/hive/pull/1086#discussion_r437861515
##########
File path:
standalone-metastore/metastore-common/src/test/java/org/apache/hadoop/hive/metastore/utils/RetryTest.java
##########
@@ -50,8 +56,49 @@ public Void execute() {
};
try {
retriable.run();
+ Assert.fail();
} catch (Exception e) {
Assert.assertEquals(RuntimeException.class, e.getClass());
}
}
+
+ @Test
+ public void testRetryFailureWithDelay() {
+ Retry<Void> retriable = new Retry<Void>(NullPointerException.class) {
+ @Override
+ public Void execute() {
+ throw new RuntimeException();
+ }
+ };
+ try {
+ retriable.runWithDelay();
+ Assert.fail();
+ } catch (Exception e) {
+ Assert.assertEquals(RuntimeException.class, e.getClass());
Review comment:
Add one more assertion for the time taken being more than total time for
all three attempts( i.e 180 sec)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 443568)
Time Spent: 20m (was: 10m)
> Add Retry for Ranger Replication
> --------------------------------
>
> Key: HIVE-23659
> URL: https://issues.apache.org/jira/browse/HIVE-23659
> Project: Hive
> Issue Type: Task
> Reporter: Aasha Medhi
> Assignee: Aasha Medhi
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23659.01.patch, HIVE-23659.02.patch,
> HIVE-23659.03.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
