[
https://issues.apache.org/jira/browse/HIVE-23738?focusedWorklogId=449732&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449732
]
ASF GitHub Bot logged work on HIVE-23738:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/20 11:17
Start Date: 23/Jun/20 11:17
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #1168:
URL: https://github.com/apache/hive/pull/1168#discussion_r444147479
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbLockManager.java
##########
@@ -99,7 +99,8 @@ LockState lock(LockRequest lock, String queryId, boolean
isBlocking, List<HiveLo
MAX_SLEEP = Math.max(15000,
conf.getTimeVar(HiveConf.ConfVars.HIVE_LOCK_SLEEP_BETWEEN_RETRIES,
TimeUnit.MILLISECONDS));
int maxNumWaits = Math.max(0,
conf.getIntVar(HiveConf.ConfVars.HIVE_LOCK_NUMRETRIES));
try {
- LOG.info("Requesting: queryId=" + queryId + " " + lock);
+ LOG.info("Requesting: queryId=" + queryId);
Review comment:
Maybe little more lengthy message could be nice :)
Just imagine seeing this in the log - what could this mean? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 449732)
Time Spent: 20m (was: 10m)
> DBLockManager::lock() : Move lock request to debug level
> --------------------------------------------------------
>
> Key: HIVE-23738
> URL: https://issues.apache.org/jira/browse/HIVE-23738
> Project: Hive
> Issue Type: Improvement
> Reporter: Rajesh Balamohan
> Assignee: Barnabas Maidics
> Priority: Trivial
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbLockManager.java#L102]
>
> For Q78 @30TB scale, it ends up dumping couple of MBs of log in info level to
> print the lock request type. If possible, this should be moved to debug level.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
