[ https://issues.apache.org/jira/browse/HIVE-23741?focusedWorklogId=451094&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-451094 ]
ASF GitHub Bot logged work on HIVE-23741: ----------------------------------------- Author: ASF GitHub Bot Created on: 25/Jun/20 14:52 Start Date: 25/Jun/20 14:52 Worklog Time Spent: 10m Work Description: asinkovits commented on a change in pull request #1159: URL: https://github.com/apache/hive/pull/1159#discussion_r445619133 ########## File path: llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheImpl.java ########## @@ -305,10 +305,10 @@ private boolean lockBuffer(LlapDataBuffer buffer, boolean doNotifyPolicy) { long offset = ranges[i].getOffset() + baseOffset; assert buffer.declaredCachedLength == LlapDataBuffer.UNKNOWN_CACHED_LENGTH; buffer.declaredCachedLength = ranges[i].getLength(); - buffer.setTag(tag); while (true) { // Overwhelmingly executes once, or maybe twice (replacing stale value). LlapDataBuffer oldVal = subCache.getCache().putIfAbsent(offset, buffer); if (oldVal == null) { + buffer.setFileCache(subCache); Review comment: Thanks, it's fixed now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 451094) Time Spent: 0.5h (was: 20m) > Store CacheTags in the file cache level > --------------------------------------- > > Key: HIVE-23741 > URL: https://issues.apache.org/jira/browse/HIVE-23741 > Project: Hive > Issue Type: Improvement > Reporter: Antal Sinkovits > Assignee: Antal Sinkovits > Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > CacheTags are currently stored for every data buffer. The strings are > internalized, but the number of cache tag objects can be reduced by moving > them to the file cache level, and back referencing them. -- This message was sent by Atlassian Jira (v8.3.4#803005)