[ 
https://issues.apache.org/jira/browse/HIVE-23755?focusedWorklogId=452182&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452182
 ]

ASF GitHub Bot logged work on HIVE-23755:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Jun/20 06:38
            Start Date: 29/Jun/20 06:38
    Worklog Time Spent: 10m 
      Work Description: pkumarsinha commented on a change in pull request #1173:
URL: https://github.com/apache/hive/pull/1173#discussion_r446802228



##########
File path: 
ql/src/test/org/apache/hadoop/hive/ql/exec/repl/TestRangerLoadTask.java
##########
@@ -263,4 +267,56 @@ public void testSuccessDisableDenyRangerPolicies() throws 
Exception {
     //Deny policy is added
     Assert.assertEquals(1, actualPolicyList.getListSize());
   }
+
+  @Test
+  public void testRangerEndpointCreation() throws Exception {
+    URIBuilder uriBuilder = new URIBuilder("http://ranger.apache.org:6080";);

Review comment:
       It tests actually URIBuilder, and not the testRanger endpoint creation 
flow. It would have been good if we could have had this test in 
RangerRestClient level. Otherwise the change looks to me.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 452182)
    Time Spent: 40m  (was: 0.5h)

> Fix Ranger Url extra slash
> --------------------------
>
>                 Key: HIVE-23755
>                 URL: https://issues.apache.org/jira/browse/HIVE-23755
>             Project: Hive
>          Issue Type: Task
>            Reporter: Aasha Medhi
>            Assignee: Aasha Medhi
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-23755.01.patch, HIVE-23755.02.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to