[ 
https://issues.apache.org/jira/browse/HIVE-23611?focusedWorklogId=452569&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452569
 ]

ASF GitHub Bot logged work on HIVE-23611:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Jun/20 18:38
            Start Date: 29/Jun/20 18:38
    Worklog Time Spent: 10m 
      Work Description: pkumarsinha commented on a change in pull request #1120:
URL: https://github.com/apache/hive/pull/1120#discussion_r447174957



##########
File path: 
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/BaseReplicationAcrossInstances.java
##########
@@ -103,6 +114,12 @@ public static void classLevelTearDown() throws IOException 
{
     replica.close();
   }
 
+  private static void setReplicaExternalBase(FileSystem fs, Map<String, 
String> confMap) throws IOException {
+    fs.mkdirs(REPLICA_EXTERNAL_BASE);
+    fullyQualifiedReplicaExternalBase =  
fs.getFileStatus(REPLICA_EXTERNAL_BASE).getPath().toString();
+    confMap.put(HiveConf.ConfVars.REPL_EXTERNAL_TABLE_BASE_DIR.varname, 
fullyQualifiedReplicaExternalBase);

Review comment:
       Yes, needed both the places. Both are different case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 452569)
    Time Spent: 0.5h  (was: 20m)

> Mandate fully qualified absolute path for external table base dir during REPL 
> operation
> ---------------------------------------------------------------------------------------
>
>                 Key: HIVE-23611
>                 URL: https://issues.apache.org/jira/browse/HIVE-23611
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Pravin Sinha
>            Assignee: Pravin Sinha
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-23611.01.patch, HIVE-23611.02.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to