[ https://issues.apache.org/jira/browse/HIVE-23805?focusedWorklogId=455998&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-455998 ]
ASF GitHub Bot logged work on HIVE-23805: ----------------------------------------- Author: ASF GitHub Bot Created on: 08/Jul/20 10:36 Start Date: 08/Jul/20 10:36 Worklog Time Spent: 10m Work Description: pvargacl commented on a change in pull request #1224: URL: https://github.com/apache/hive/pull/1224#discussion_r451446059 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java ########## @@ -1262,8 +1262,8 @@ public static boolean isAcid(FileSystem fileSystem, Path directory, * @throws IOException on filesystem errors */ public static Directory getAcidState(FileSystem fileSystem, Path candidateDirectory, Configuration conf, - ValidWriteIdList writeIdList, Ref<Boolean> useFileIds, boolean ignoreEmptyFiles) throws IOException { - return getAcidState(fileSystem, candidateDirectory, conf, writeIdList, useFileIds, ignoreEmptyFiles, null); + ValidWriteIdList writeIdList, ValidTxnList validTxnList, Ref<Boolean> useFileIds, boolean ignoreEmptyFiles) throws IOException { + return getAcidState(fileSystem, candidateDirectory, conf, writeIdList, validTxnList, useFileIds, ignoreEmptyFiles, null); Review comment: I will create a separate issue to change getAcidState to get just one parameter with builder pattern, because this is getting out of hand ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 455998) Time Spent: 20m (was: 10m) > ValidReadTxnList need not be constructed multiple times in > AcidUtils::getAcidState > ----------------------------------------------------------------------------------- > > Key: HIVE-23805 > URL: https://issues.apache.org/jira/browse/HIVE-23805 > Project: Hive > Issue Type: Improvement > Reporter: Rajesh Balamohan > Assignee: Peter Varga > Priority: Major > Labels: pull-request-available > Attachments: Screenshot 2020-07-06 at 4.53.44 PM.png > > Time Spent: 20m > Remaining Estimate: 0h > > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java#L1273] > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java#L1286] > > {code:java} > String s = conf.get(ValidTxnList.VALID_TXNS_KEY); > > > if(!Strings.isNullOrEmpty(s)) { > > ... > ... > validTxnList.readFromString(s); > > > } {code} > > > !Screenshot 2020-07-06 at 4.53.44 PM.png|width=610,height=621! > AM spends good amount of CPU parsing the same validtxnlist multiple times. > -- This message was sent by Atlassian Jira (v8.3.4#803005)