[ 
https://issues.apache.org/jira/browse/HIVE-23780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153742#comment-17153742
 ] 

Naveen Gangam commented on HIVE-23780:
--------------------------------------

[~mustafaiman] [~pvary] I dont have enough context with this AcidListener and 
why its being done here but would it make sense to do this logic as part of the 
dropTable prior to committing the table drop, in the ObjectStore itself? The 
net effect with the proposed fix is about the same (other than order of 
dropping rows) but this appears cleaner and more predictable.
Just wanted to know your thoughts on it. Thanks


> Fail dropTable if acid cleanup fails
> ------------------------------------
>
>                 Key: HIVE-23780
>                 URL: https://issues.apache.org/jira/browse/HIVE-23780
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore, Standalone Metastore, Transactions
>            Reporter: Mustafa Iman
>            Assignee: Mustafa Iman
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Acid cleanup happens after dropTable is committed. If cleanup fails for some 
> reason, there are leftover entries in acid tables. This later causes dropped 
> table's name to be unusable by new tables.
> [~pvary] [~ngangam]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to