[
https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=456488&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456488
]
ASF GitHub Bot logged work on HIVE-23800:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/20 09:11
Start Date: 09/Jul/20 09:11
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #1205:
URL: https://github.com/apache/hive/pull/1205#issuecomment-656010567
Hey @dengzhhu653 this comment might have not caught your attention:
> I don't think this is a move in the right direction; you are moving the
`HS2::stop` out into an "optional" hook stuff...which could be just removed by
a conf change - I think it should remain part of the system.
>
> ...your objective seems to be to add diagnostic capabilities around when
the OOM happens; I think in case you get an oom the best is to capture a
heapdump...and analyze that: to see what's wrong
> but I may not know all the details...
>
> I think creating some generic hook stuff which also gets notified about
OOM - would be a better option
what do you think about creating some more generic hook stuff (and add -
and then we can tie that in into more places if needed...if we put OOM in the
name of things we may not re-use it later
I've noticed one more thing: do we really need to put the `HS2` instance
into the hookcontext? I don't think we wan't to guarantee that the interface of
that class will not change...and as such: it should not be placed in a context
accesible by extensions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 456488)
Time Spent: 1h 20m (was: 1h 10m)
> Make HiveServer2 oom hook interface
> -----------------------------------
>
> Key: HIVE-23800
> URL: https://issues.apache.org/jira/browse/HIVE-23800
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
> Reporter: Zhihua Deng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Make oom hook an interface of HiveServer2, so user can implement the hook to
> do something before HS2 stops, such as dumping the heap or altering the
> devops.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
