[
https://issues.apache.org/jira/browse/HIVE-23638?focusedWorklogId=456588&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456588
]
ASF GitHub Bot logged work on HIVE-23638:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/20 12:51
Start Date: 09/Jul/20 12:51
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #1161:
URL: https://github.com/apache/hive/pull/1161#discussion_r452193076
##########
File path:
common/src/java/org/apache/hadoop/hive/common/jsonexplain/DagJsonParserUtils.java
##########
@@ -26,9 +28,13 @@
public class DagJsonParserUtils {
- public static List<String> OperatorNoStats = Arrays.asList(new String[] {
"File Output Operator",
+ private static final List<String> operatorNoStats = Arrays.asList(new
String[] { "File Output Operator",
Review comment:
Well, it kinda needs to be static as Op class is using it directly
within getNameWithOpIdStats method
##########
File path: common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java
##########
@@ -133,6 +134,7 @@ public static void setPerfLogger(PerfLogger
resetPerfLogger) {
* @param callerName the logging object to be used.
* @param method method or ID that identifies this perf log element.
*/
+ @SuppressFBWarnings(value = "NM_METHOD_NAMING_CONVENTION", justification =
"Intended")
public void PerfLogBegin(String callerName, String method) {
Review comment:
Sure, opened HIVE-23823 for tracking this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 456588)
Time Spent: 2h (was: 1h 50m)
> Fix FindBug issues in hive-common
> ---------------------------------
>
> Key: HIVE-23638
> URL: https://issues.apache.org/jira/browse/HIVE-23638
> Project: Hive
> Issue Type: Sub-task
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Labels: pull-request-available
> Attachments: spotbugsXml.xml
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> mvn -Pspotbugs
> -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugin.surefire.SurefirePlugin=INFO
> -pl :hive-common test-compile
> com.github.spotbugs:spotbugs-maven-plugin:4.0.0:check
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
