[ https://issues.apache.org/jira/browse/HIVE-23483?focusedWorklogId=456645&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456645 ]
ASF GitHub Bot logged work on HIVE-23483: ----------------------------------------- Author: ASF GitHub Bot Created on: 09/Jul/20 14:13 Start Date: 09/Jul/20 14:13 Worklog Time Spent: 10m Work Description: pgaref commented on pull request #1207: URL: https://github.com/apache/hive/pull/1207#issuecomment-656152607 > I've seen some additional usage, however I'm not sure how these are utilized, thus I left it in so far: > > ``` > ql/src/java/org/apache/hadoop/hive/ql/io/HiveBinaryOutputFormat.java:76: // DynamicSerDe always writes out BytesWritable > serde/src/java/org/apache/hadoop/hive/serde2/thrift/TBinarySortableProtocol.java:150: // If the struct is null and level > 1, DynamicSerDe will call > serde/src/java/org/apache/hadoop/hive/serde2/thrift/TBinarySortableProtocol.java:418: // slight hack to communicate to DynamicSerDe that the field ids are not > serde/src/java/org/apache/hadoop/hive/serde2/thrift/TCTLSeparatedProtocol.java:667: // slight hack to communicate to DynamicSerDe that the field ids are not > ``` I am under the impression that TCTLSeparatedProtocol is also not only used by DynamicSerDe. Regarding the DynamicSerDe comments I would either try to track why they are there (or if the functionality is needed at all) -- or completely remove them to avoid confusion. Backup option would be to note DynamicSerDe is now not supported (as you did above) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 456645) Time Spent: 1h 20m (was: 1h 10m) > Remove DynamicSerDe > ------------------- > > Key: HIVE-23483 > URL: https://issues.apache.org/jira/browse/HIVE-23483 > Project: Hive > Issue Type: Task > Reporter: Ashutosh Chauhan > Assignee: David Lavati > Priority: Major > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > It is used to read thrift data files. AFAIK no one uses thrift for data > serialization. -- This message was sent by Atlassian Jira (v8.3.4#803005)