[ https://issues.apache.org/jira/browse/HIVE-23853?focusedWorklogId=459423&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459423 ]
ASF GitHub Bot logged work on HIVE-23853: ----------------------------------------- Author: ASF GitHub Bot Created on: 15/Jul/20 17:24 Start Date: 15/Jul/20 17:24 Worklog Time Spent: 10m Work Description: pvary commented on a change in pull request #1256: URL: https://github.com/apache/hive/pull/1256#discussion_r455212090 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFile.java ########## @@ -161,6 +163,7 @@ private static synchronized MemoryManager getThreadLocalOrcLlapMemoryManager(fin LlapProxy.isDaemon()) { memory(getThreadLocalOrcLlapMemoryManager(conf)); } + isCompaction = tableProperties != null && "true".equals(tableProperties.getProperty(AcidUtils.COMPACTOR_TABLE_PROPERTY)); Review comment: Done. Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 459423) Time Spent: 40m (was: 0.5h) > CRUD based compaction also should update ACID file version metadata > ------------------------------------------------------------------- > > Key: HIVE-23853 > URL: https://issues.apache.org/jira/browse/HIVE-23853 > Project: Hive > Issue Type: Improvement > Components: Transactions > Reporter: Peter Vary > Assignee: Peter Vary > Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > Current CRUD compaction does not update the file metadata to contain the ACID > version. Also the {{_orc_acid_version}} version file is not created. > We should do this to be consistent across the board. -- This message was sent by Atlassian Jira (v8.3.4#803005)