[
https://issues.apache.org/jira/browse/HIVE-23901?focusedWorklogId=462333&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-462333
]
ASF GitHub Bot logged work on HIVE-23901:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jul/20 01:26
Start Date: 23/Jul/20 01:26
Worklog Time Spent: 10m
Work Description: belugabehr commented on pull request #1301:
URL: https://github.com/apache/hive/pull/1301#issuecomment-662777247
The current implementation is purposeful. This is an abstract class. The
idea is that every subclass gets it's own logger. With the implementation
proposed in this PR, every subclass will have the same logger. This makes
logging very difficult to tease out.
Can you please elaborate on the performance implications here? If it's
absolutely required, it is better that each subclass have their own Logger than
to inherit a logger in this fashion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 462333)
Time Spent: 20m (was: 10m)
> Overhead of Logger in ColumnStatsMerger damage the performance
> --------------------------------------------------------------
>
> Key: HIVE-23901
> URL: https://issues.apache.org/jira/browse/HIVE-23901
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore, Statistics
> Reporter: Yu-Wen Lai
> Assignee: Yu-Wen Lai
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When aggregating the column stats for a big partitioned table, we observed a
> large proportion of time spent in getLogger(). If we declare it as static,
> the execution time of aggregate can be greatly improved.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
