[
https://issues.apache.org/jira/browse/HIVE-23915?focusedWorklogId=462865&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-462865
]
ASF GitHub Bot logged work on HIVE-23915:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jul/20 08:15
Start Date: 24/Jul/20 08:15
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #1303:
URL: https://github.com/apache/hive/pull/1303#discussion_r459912261
##########
File path: .github/pull_request_template.md
##########
@@ -1,6 +1,46 @@
-## NOTICE
+<!--
+Thanks for sending a pull request! Here are some tips for you:
+ 1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
+ 2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
+ 3. Ensure you have added or run the appropriate tests for your PR:
+ 4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
+ 5. Be sure to keep the PR description updated to reflect all changes.
+ 6. Please write your PR title to summarize what this PR proposes.
+ 7. If possible, provide a concise example to reproduce the issue for a
faster review.
-Please create an issue in ASF JIRA before opening a pull request,
-and you need to set the title of the pull request which starts with
-the corresponding JIRA issue number. (e.g. HIVE-XXXXX: Fix a typo in YYY)
-For more details, please see
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
+-->
+
+### What changes were proposed in this pull request?
+<!--
+Please clarify what changes you are proposing. The purpose of this section is
to outline the changes and how this PR fixes the issue.
+If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
+ 1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
+ 2. If you fix some SQL features, you can provide some references of other
DBMSes.
+ 3. If there is design documentation, please add the link.
+ 4. If there is a discussion in the mailing list, please add the link.
+-->
+
+
+### Why are the changes needed?
+<!--
+Please clarify why the changes are needed. For instance,
+ 1. If you propose a new API, clarify the use case for a new API.
+ 2. If you fix a bug, you can clarify why it is a bug.
+-->
+
+
+### Does this PR introduce _any_ user-facing change?
+<!--
+Note that it means *any* user-facing change including all aspects such as the
documentation fix.
+If yes, please clarify the previous behavior and the change this PR proposes -
provide the console output, description and/or an example to show the behavior
difference if possible.
+If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
Review comment:
This is tough! Contributors should compare there changes against a
released Spark version :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 462865)
Time Spent: 20m (was: 10m)
> Improve Github PR Template
> --------------------------
>
> Key: HIVE-23915
> URL: https://issues.apache.org/jira/browse/HIVE-23915
> Project: Hive
> Issue Type: Improvement
> Components: Documentation
> Reporter: Hunter Logan
> Assignee: Hunter Logan
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Having this repo on github is great and will probably increase the number of
> contributors tremendously. With that there will of course be an influx in the
> number of PRs so it's going to be critical to make reviewing PRs as easy as
> possible.
> Using
> [https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE]
> as a template improve the template to make reviewing easier for contributors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
